Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDS Verification: add 3 component pine_wood_TGA cases to dataplot and… #13940

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

rmcdermo
Copy link
Contributor

… tune parameters to better match Anca-Couce data

… tune parameters to better match Anca-Couce data
@rmcdermo rmcdermo merged commit e11400e into firemodels:master Dec 23, 2024
1 check passed
@rmcdermo
Copy link
Contributor Author

@ericvmueller Do these plots live in any of the guides yet? I am not finding them. Nor do I find "pine_wood_TGA" label. So, I'm wondering how we are getting away with this. Usually firebot complains if a case is in dataplot but not referenced in a section of one of the guides.

@ericvmueller
Copy link
Contributor

Hmm AFAIK I didn't do anything special - I didn't know that was something which would cause a complaint and wasn't aiming to avoid it. As far as putting it in the guide I think we had gone back and forth on whether we needed/wanted another pyroylsis case, but with the Kashiwagi case progressing it probably makes sense. Happy to put something in but will need to check with you on the new parameters. I'll be back in the office on Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants