Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue fixes & peer dependency fix #71

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Issue fixes & peer dependency fix #71

merged 6 commits into from
Jan 3, 2024

Conversation

erhant
Copy link
Member

@erhant erhant commented Jan 3, 2024 •
edited
Loading

  • Resolves Modifier refactors #56 there is no need to refactor anymore, and async modifiers are allowed.
  • Fixes Set Warp SDK to ^1.4.26 #63 by making it a peer dependency
  • Due to using peer dependencies now, we have moved from yarn to pnpm on all fronts (workflows, local repo)
  • ethers and snarkjs plugins are also moved out of dependencies to optionals, as you only need them if you are using proof & verifications.
  • Resolves Add transfer utility #46 with added transfer CLI command
  • Resolves Update Bundlr to irys #59 with the updated simple example
  • Added whoami method to CLI to print about information about a wallet

@erhant erhant requested a review from fco-fbatch January 3, 2024 15:50
@erhant erhant added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 3, 2024
@erhant erhant self-assigned this Jan 3, 2024
fco-fbatch
fco-fbatch approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@fco-fbatch fco-fbatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erhant erhant merged commit 611b1c4 into master Jan 3, 2024
@erhant erhant deleted the erhant/peer-deps branch January 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fco-fbatch fco-fbatch fco-fbatch approved these changes

Assignees

@erhant erhant

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Warp SDK to ^1.4.26 Update Bundlr to irys Modifier refactors Add transfer utility
2 participants
@erhant @fco-fbatch