Update ModuleCustomTrait.php

[magicsunday]

Adding an additional method call to allow the processing of the response from the get latest version request. With this it would be possible for me to query the version information directly from githubs release json without the need for an exta latest-release.txt file. Using the method I could easily parse the JSON response and extract the version information.

[magicsunday]

Do you got some time to look at this?

[ric2016]

I don't think this is necessary - why don't you just adjust customModuleLatestVersion() in your custom module, according to your specific needs? (Adjustments of that method are required anyway in case of a different versioning scheme, and/or a different cache expiration period, or should we have separate methods for these as well? I don't think so.)

[magicsunday]

Because of duplicate code. You should avoid it where ever it is possible. As "customModuleLatestVersion" is a method from the core there is always a possibility of change. Maybe it contains a bug, so it would require me to fix this in my module too but my module shouldn't know about the core. So intercepting the core code using a callback or hook would be the better solution instead of duplicating it. Currently the method only accepts a single solution of querying module information without greatly modifying it.

[arbor95]

Seems: will not be implemented->close

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.31%. Comparing base (95621db) to head (f8cdec5).

Files with missing lines	Patch %	Lines
app/Module/ModuleCustomTrait.php	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3661      +/-   ##
============================================
- Coverage     35.31%   35.31%   -0.01%     
- Complexity    11406    11407       +1     
============================================
  Files          1179     1179              
  Lines         47865    47867       +2     
============================================
  Hits          16905    16905              
- Misses        30960    30962       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ekdahl]

Adding this would be great.