Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options for charts blocks #4796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

papjul
Copy link
Contributor

@papjul papjul commented Mar 20, 2023

Add additional dynamic options according to the type of chart.

Additional fix: don't display in the <select> type, charts that are disabled.

image

image

@papjul papjul force-pushed the charts-block-config branch from 0e7f8f3 to 6771bca Compare July 9, 2023 09:09
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #4796 (6771bca) into main (4867704) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4796      +/-   ##
============================================
- Coverage     30.97%   30.94%   -0.04%     
- Complexity    11366    11370       +4     
============================================
  Files          1168     1168              
  Lines         47868    47915      +47     
============================================
  Hits          14825    14825              
- Misses        33043    33090      +47     
Impacted Files Coverage Δ
app/Module/ChartsBlockModule.php 0.00% <0.00%> (ø)
app/Module/DescendancyChartModule.php 0.00% <ø> (ø)
app/Module/HourglassChartModule.php 0.00% <ø> (ø)
app/Module/PedigreeChartModule.php 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant