Yandex Metrica counter snippet #4895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azlydnev yandex metrica
Codecov Report
@@ Coverage Diff @@
## main #4895 +/- ##
============================================
- Coverage 32.08% 32.07% -0.02%
- Complexity 11386 11395 +9
============================================
Files 1170 1171 +1
Lines 47954 47974 +20
============================================
Hits 15388 15388
- Misses 32566 32586 +20
|
fisharebest
reviewed
Nov 6, 2023
| k=e.createElement(t),a=e.getElementsByTagName(t)[0],k.async=1,k.src=r,a.parentNode.insertBefore(k,a)}) | ||
| (window, document, "script", "https://mc.yandex.ru/metrika/tag.js", "ym"); | ||
|
|
||
| ym(<?= json_encode((int) ($YANDEX_METRICA_ID ?? ''), JSON_THROW_ON_ERROR) ?> , "init", { |
There was a problem hiding this comment.
If we are casting this value to an int, then we do not need json_encode()?
Also, $YANDEX_METRICA_ID can never be null. So we do not need ?? ''
fisharebest
reviewed
Nov 6, 2023
|
|
||
| <div class="row mb-3"> | ||
| <label for="YANDEX_METRICA_ID" class="col-sm-3 col-form-label"> | ||
| <?= /* I18N: A configuration setting */ I18N::translate('Yandex Metica') ?> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Yandex Merica counter.
Used standard snippet
https://metrika.yandex.ru/