chore: update Rust version and fix clippy warnings. (#460)

Cargo.toml

@@ -17,5 +17,8 @@ authors       = ["The Fish Folk & Spicy Lobster Developers"]
 categories    = ["game-development", "game-engines", "wasm", "data-structures"]
 keywords      = ["bones", "bevy", "scripting", "ecs", "framework"]
 
+[workspace.lints.clippy]
+correctness = "warn"
+
 [profile.release]
 lto = true

framework_crates/bones_asset/src/parse.rs

@@ -6,23 +6,6 @@ use serde::Deserialize;
 
 use crate::prelude::*;
 
-/// Deserializeable struct for schema files.
-///
-/// This struct is required because you can't use `serde(with = "..")` directly on the [`Schema`]
-/// enum to make it use nested struct syntax instead of YAML tags for enum representation. Avoiding
-/// tags is necessary because we use nested enums such as `vec: primitive: string`.
-#[derive(Debug, Clone)]
-#[cfg_attr(feature = "serde", derive(serde::Deserialize))]
-pub struct SchemaFile {
-    /// The schema defined in the file
-    #[cfg_attr(
-        feature = "serde",
-        serde(with = "serde_yaml::with::singleton_map_recursive")
-    )]
-    #[cfg_attr(feature = "serde", serde(flatten))]
-    pub schema: Schema,
-}
-
 impl FromStr for AssetPackReq {
     type Err = String;
     fn from_str(s: &str) -> Result<Self, Self::Err> {

framework_crates/bones_asset/src/server.rs

@@ -888,7 +888,7 @@ impl AssetServer {
                 if T::schema() == <SchemaBox as HasSchema>::schema() {
                     // SOUND: the above comparison verifies that T is concretely a SchemaBox so &Schemabox
                     // is the same as &T.
-                    Some(unsafe { std::mem::transmute(asset) })
+                    Some(unsafe { std::mem::transmute::<&SchemaBox, &T>(asset) })
                 } else {
                     asset.try_cast_ref().ok()
                 }
@@ -964,7 +964,7 @@ impl AssetServer {
             if T::schema() == <SchemaBox as HasSchema>::schema() {
                 // SOUND: the above comparison verifies that T is concretely a SchemaBox so &mut Schemabox
                 // is the same as &mut T.
-                unsafe { std::mem::transmute(asset) }
+                unsafe { std::mem::transmute::<&mut SchemaBox, &mut T>(asset) }
             } else {
                 asset.cast_mut()
             }

framework_crates/bones_framework/Cargo.toml

@@ -66,6 +66,11 @@ image_ico = ["image/ico"]
 ## Enable BMP image loader.
 image_bmp = ["image/bmp"]
 
+#! ### Debuging Features
+
+## Simulate dramatic network latency by inserting random sleeps into the networking code. This is extremely cheap and hacky but may be useful.
+debug-network-slowdown = []
+
 document-features = ["dep:document-features"]
 
 [dependencies]

framework_crates/bones_framework/src/animation.rs

@@ -28,11 +28,6 @@ pub struct AnimatedSprite {
     pub repeat: bool,
 }
 
-#[cfg(feature = "serde")]
-fn default_true() -> bool {
-    true
-}
-
 /// Component that may be added to an [`AtlasSprite`] to control which animation, out of a set of
 /// animations, is playing.
 ///
@@ -45,7 +40,6 @@ pub struct AnimationBankSprite {
     /// The collection of animations in this animation bank.
     // TODO: Put Animation Frames in an `Arc` to Avoid Snapshot Clone Cost.
     pub animations: SMap<Ustr, AnimatedSprite>,
-    #[cfg_attr(feature = "serde", serde(default))]
     /// The last animation that was playing.
     pub last_animation: Ustr,
 }

framework_crates/bones_framework/src/debug.rs

@@ -79,7 +79,7 @@ pub fn frame_diagnostic_window(
                         state.reset();
                     }
 
-                    ui.monospace(&format!(
+                    ui.monospace(format!(
                         "{label:20}: {fps:4.0}{suffix:3} ( {min:4.0}{suffix:3}, {avg:4.0}{suffix:3}, {max:4.0}{suffix:3} )",
                         // label = localization.get("frames-per-second"),
                         label = "Frames Per Second",
@@ -90,7 +90,7 @@ pub fn frame_diagnostic_window(
                         avg = state.fps_avg,
                         max = state.max_fps,
                     ));
-                    ui.monospace(&format!(
+                    ui.monospace(format!(
                         "{label:20}: {fps:4.1}{suffix:3} ( {min:4.1}{suffix:3}, {avg:4.0}{suffix:3}, {max:4.1}{suffix:3} )",
                         // label = localization.get("frame-time"),
                         label = "Frame Time",

framework_crates/bones_framework/src/networking.rs

@@ -136,7 +136,7 @@ pub struct NetworkMatchSocket(Arc<dyn NetworkSocket>);
 
 /// Wraps [`ggrs::Message`] with included `match_id`, used to determine if message received
 /// from current match.
-#[derive(Serialize, Deserialize, Debug, Clone)]
+#[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct GameMessage {
     /// Socket match id
     pub match_id: u8,
@@ -575,8 +575,8 @@ where
         // to integer so our computed timestep will match  that of ggrs.
         let network_fps = (simulation_fps * NETWORK_FRAME_RATE_FACTOR) as f64;
         let network_fps = network_fps
-            .max(std::usize::MIN as f64)
-            .min(std::usize::MAX as f64)
+            .max(usize::MIN as f64)
+            .min(usize::MAX as f64)
             .round() as usize;
 
         // There may be value in dynamically negotitaing these values based on client's pings

framework_crates/bones_framework/src/networking/online.md

@@ -46,9 +46,8 @@ When a client connects to the matchmaking server, the very first thing it will d
 [`RequestMatch`][crate::external::bones_matchmaker_proto::MatchmakerRequest::RequestMatch] message
 to the server over a reliable channel.
 
-This message contains the [`MatchInfo`][crate::external::bones_matchmaker_proto::MatchInfo] that
-tells the server how many players the client wants to connect to for the match, along with an
-arbitrary byte sequence for the `match_data`.
+This message contains the [`MatchInfo`] that tells the server how many players the client wants to
+connect to for the match, along with an arbitrary byte sequence for the `match_data`.
 
 In order for players to end up in the same match as each-other, they must specify the _exact_ same
 `MatchInfo`, including the `match_data`. We use the `match_data` as a way to specify which game mode

framework_crates/bones_framework/src/networking/socket.rs

@@ -13,7 +13,6 @@ use super::{GameMessage, NetworkSocket, SocketTarget, RUNTIME};
 /// The [`NetworkSocket`] implementation.
 #[derive(Debug, Clone)]
 pub struct Socket {
-    ///
     pub connections: Vec<(u32, iroh_quinn::Connection)>,
     pub ggrs_receiver: async_channel::Receiver<(u32, GameMessage)>,
     pub reliable_receiver: async_channel::Receiver<(u32, Vec<u8>)>,

framework_crates/bones_framework/src/render/camera.rs

@@ -165,7 +165,7 @@ impl CameraShake {
         decay_rate: f32,
     ) -> Self {
         let mut shake = Self::new(max_angle_deg, max_offset, speed, decay_rate);
-        shake.trauma = trauma.min(1.0).max(0.0);
+        shake.trauma = trauma.clamp(0.0, 1.0);
         shake
     }
 

framework_crates/bones_framework/src/time/stopwatch.rs

@@ -21,8 +21,7 @@ use std::time::Duration;
 /// assert!(stopwatch.paused());
 /// assert_eq!(stopwatch.elapsed_secs(), 0.0);
 /// ```
-#[derive(Clone, Debug, Default)]
-#[cfg_attr(feature = "serialize", derive(serde::Deserialize, serde::Serialize))]
+#[derive(Clone, Debug, Default, serde::Deserialize, serde::Serialize)]
 pub struct Stopwatch {
     paused: bool,
     elapsed: Duration,

framework_crates/bones_framework/src/time/timer.rs

@@ -402,8 +402,9 @@ impl Timer {
 }
 
 /// Specifies [`Timer`] behavior.
-#[derive(Debug, Clone, Copy, Eq, PartialEq, Hash, Default)]
-#[cfg_attr(feature = "serialize", derive(serde::Deserialize, serde::Serialize))]
+#[derive(
+    Debug, Clone, Copy, Eq, PartialEq, Hash, Default, serde::Deserialize, serde::Serialize,
+)]
 pub enum TimerMode {
     /// Run once and stop.
     #[default]

framework_crates/bones_schema/macros/src/lib.rs

@@ -64,7 +64,7 @@ macro_rules! throw {
 ///
 /// ## derive_type_data attribute
 /// This attribute is simply a shortcut equivalent to using the type_data attribute
-/// with any type's FromType<YourHasSchemaType> implementation like so:
+/// with any type's `FromType<YourHasSchemaType>` implementation like so:
 /// ```ignore
 /// #[derive(HasSchema, Clone, Default)]
 /// #[type_data(<OtherType as FromType<Data>>::from_type())]

framework_crates/bones_scripting/src/lua/bindings/schema.rs

@@ -60,7 +60,7 @@ pub fn metatable(ctx: Context) -> Table {
             Callback::from_fn(&ctx, move |ctx, _fuel, mut stack| {
                 let this: UserData = stack.consume(ctx)?;
                 let this = this.downcast_static::<&Schema>()?;
-                let s = piccolo::String::from_slice(&ctx, &format!("Schema({})", this.full_name));
+                let s = piccolo::String::from_slice(&ctx, format!("Schema({})", this.full_name));
 
                 stack.push_front(Value::String(s));
                 Ok(CallbackReturn::Return)

other_crates/bones_matchmaker/src/matchmaker.rs

@@ -160,7 +160,7 @@ async fn impl_matchmaker(ep: iroh_net::Endpoint, conn: Connection) -> anyhow::Re
                             let random_seed = rand::random();
 
                             for (idx, conn) in members_to_join.iter().enumerate() {
-                                let id = get_remote_node_id(&conn)?;
+                                let id = get_remote_node_id(conn)?;
                                 let mut addr = NodeAddr::new(id);
                                 if let Some(info) = ep.connection_info(id) {
                                     if let Some(relay_url) = info.relay_url {

rust-toolchain.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "1.76"
+channel = "1.81"