fix(sprite): reposition rope tiles in atlas for padding #1041
Conversation
|
Yeah a rendering fix did not seem very clear, I think this is good, I had not tried this but good to know can be fixed in authoring of the tilesets. Haven't had a chance to boot up game and double check - I see level 3 is updated. Do you happen to know if any other levels use these rope tiles or just 3? If no other levels will go ahead and merge. Thanks! |
|
Good catch, levels 7 & 8 also have ropes that were broken. Those are now fixed: Level 7
Level 8
|
|
Well I found a few more, the railing and flag in this atlas have the same issue. EDIT: and the crow's nest |
Ah gotcha, those were much less noticeable to me. Good to know. Should I go ahead and merge this (we can open a new issue for those)? If want to update PR for anything I can leave it open. |
|
Yeah I think this is good to merge as-is. I can do the others in a follow-up. |
Follow-up to #1041. ## Changes - Fix the rest of the sprite artifacts in `ship_decorations` ## Things Worth Mentioning - Changed levels 3 & 8 to use YAML flow style so that I could find tiles by position (e.g. by searching for `pos: [13, 10]`: Before: ```yaml tiles: - pos: - 1 - 2 idx: 3 collision: Solid ``` After: ```yaml tiles: - { pos: [1, 2], idx: 3, collision: Solid } ``` - Add script to get the layer names in any level files that use specific tile indexes of a tilemap: ```yaml # Find all crow's nests (indexes 30-32) from ship_decorations $ ./scripts/find-atlas-tiles.sh ship_decorations.atlas.yaml '[30,31,32]' ./assets/map/levels/level_3.map.yaml - foreground ./assets/map/levels/level_8.map.yaml - foreground # This tells us levels 3 and 8 have crow's nests in their "foreground" layer ``` - Fix git attributes for text files in `assets/` & `old_assets/` which shouldn't be treated as binary (yaml, txt, ftl)
Fixes #1014 (for now).
It sounds like a proper fix entails significant work; but to fix the immediate issue we can move the rope tiles away from any others so that those adjacent to them are blank.
Before
After