feat: Round scoring + map transitions #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settings to Attachment. Provides additional control to sprite orientation / position when attached.
DRuppFv
pushed a commit
to DRuppFv/jumpy
that referenced
this pull request
Apr 20, 2024
This change adds basic components of scoring rounds and map transitions. When 1 or fewer players are alive, round is scored after a few seconds, and transitions to new map. ### Round Scoring Round scoring starts when one or fewer players are left. After a few seconds, winner is chosen. If last player dies before this, it is a draw. I added a "programmer art" rendition of a +1 sprite that pops up over winners head, and grabbed this [sound effect](https://freesound.org/people/Samuel54tw/sounds/705735/). Definitely can replace / upgrade these but wanted to get something in for now. ### Map Transition There is a new "All Maps" button on map select screen that creates a pool of all maps, otherwise can select single map. Next map is random, though due to fixed seed, I think ordering may be identical each time. Can improve this later on. Map transition only occurs once all players have confirmed frame it occurred on (for network play). Game session is restarted, and net session runner + ggrs session are re-created with existing socket. - There's a bit of delay + black screen on map transition in network play due to ggrs session synchronizing before advancing. Something to improve in the future. In local it is instant. ### Attachment Changes Added a `sync_flip` and `offset_inherits_rotation` to give additional control on what is applied to attachment from parent. The win indicator is an attachment with a lerped offset over time to make it rise. Added an `AttachmentEase` component and some attachment meta types used by win indicator here.
DRuppFv
pushed a commit
to DRuppFv/jumpy
that referenced
this pull request
Apr 20, 2024
This change adds basic components of scoring rounds and map transitions. When 1 or fewer players are alive, round is scored after a few seconds, and transitions to new map. ### Round Scoring Round scoring starts when one or fewer players are left. After a few seconds, winner is chosen. If last player dies before this, it is a draw. I added a "programmer art" rendition of a +1 sprite that pops up over winners head, and grabbed this [sound effect](https://freesound.org/people/Samuel54tw/sounds/705735/). Definitely can replace / upgrade these but wanted to get something in for now. ### Map Transition There is a new "All Maps" button on map select screen that creates a pool of all maps, otherwise can select single map. Next map is random, though due to fixed seed, I think ordering may be identical each time. Can improve this later on. Map transition only occurs once all players have confirmed frame it occurred on (for network play). Game session is restarted, and net session runner + ggrs session are re-created with existing socket. - There's a bit of delay + black screen on map transition in network play due to ggrs session synchronizing before advancing. Something to improve in the future. In local it is instant. ### Attachment Changes Added a `sync_flip` and `offset_inherits_rotation` to give additional control on what is applied to attachment from parent. The win indicator is an attachment with a lerped offset over time to make it rise. Added an `AttachmentEase` component and some attachment meta types used by win indicator here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds basic components of scoring rounds and map transitions. When 1 or fewer players are alive, round is scored after a few seconds, and transitions to new map.
Round Scoring
Round scoring starts when one or fewer players are left. After a few seconds, winner is chosen. If last player dies before this, it is a draw.
I added a "programmer art" rendition of a +1 sprite that pops up over winners head, and grabbed this sound effect. Definitely can replace / upgrade these but wanted to get something in for now.
Map Transition
There is a new "All Maps" button on map select screen that creates a pool of all maps, otherwise can select single map. Next map is random, though due to fixed seed, I think ordering may be identical each time. Can improve this later on.
Map transition only occurs once all players have confirmed frame it occurred on (for network play). Game session is restarted, and net session runner + ggrs session are re-created with existing socket.
Attachment Changes
Added a
sync_flipandoffset_inherits_rotationto give additional control on what is applied to attachment from parent. The win indicator is an attachment with a lerped offset over time to make it rise. Added anAttachmentEasecomponent and some attachment meta types used by win indicator here.