Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable declarations #59

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Jan 3, 2025

PR Overview

This PR will address the following Issue/Feature: Internal Height ticket

This PR will result in the following new package version: 0.11.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Macro Updates

  • Introduced a local version of the fill_pass_through_columns macro that directly calls the variables within our staging models. This removes the existing string-to-variable conversion and leads to cleaner parsing.
  • This new macro is applied to all staging models with passthrough column functionality, and replaces the existing fill_pass_through_columns macro.
    • stg_netsuite and stg_netsuite2 models impacted include: accounts, classes, consolidated_exchange_rates, customers, departments, items, locations, subsidiaries, transaction_lines, transactions, and vendors.
  • Similar changes are being made on a simultaneous release to the persist_pass_through_columns macro in the dbt_netsuite package. See the release notes for more details.
  • The process for adding passthrough columns remains unchanged. Consult the README for more details.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Ran on multiple variations of passthrough columns (with name, with alias, with multiple passthrough columns, with no passthrough columns).

If you had to summarize this PR in an emoji, which would it be?

🚲

@fivetran-avinash fivetran-avinash self-assigned this Jan 6, 2025
@fivetran-avinash fivetran-avinash marked this pull request as ready for review January 6, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant