Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Internal Height ticket
This PR will result in the following new package version: 0.11.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Macro Updates
fill_pass_through_columns
macro that directly calls the variables within our staging models. This removes the existing string-to-variable conversion and leads to cleaner parsing.fill_pass_through_columns
macro.stg_netsuite
andstg_netsuite2
models impacted include:accounts
,classes
,consolidated_exchange_rates
,customers
,departments
,items
,locations
,subsidiaries
,transaction_lines
,transactions
, andvendors
.persist_pass_through_columns
macro in thedbt_netsuite
package. See the release notes for more details.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Ran on multiple variations of passthrough columns (with name, with alias, with multiple passthrough columns, with no passthrough columns).
If you had to summarize this PR in an emoji, which would it be?
🚲