Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting database and schema via environment variable #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bretwalker
Copy link

@bretwalker bretwalker commented Feb 24, 2023

Are you a current Fivetran customer?
Yes

What change(s) does this PR introduce?
Adds the ability to set source database and schema via environment variable.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

If fetching settings from environment variables fails, defaults will be returned, causing a fallback to the current var values in src_zendesk.yml.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

I tested by setting both the new var values (zendesk_schema_env_var and zendesk_database_env_var) and the current var values (zendesk_schema and zendesk_database) and running dbt build against a Snowflake warehouse.

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant