Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial struct support #418

Merged
merged 30 commits into from
Aug 22, 2024
Merged

Initial struct support #418

merged 30 commits into from
Aug 22, 2024

Conversation

NeoQuix
Copy link
Collaborator

@NeoQuix NeoQuix commented Jun 14, 2024

Add initial struct support in DeWolf.

@NeoQuix
Copy link
Collaborator Author

NeoQuix commented Jun 14, 2024

Todo: Add wrapper in enum (globals.py) to fix #214

@blattm
Copy link
Collaborator

blattm commented Jun 14, 2024 •
edited
Loading

Tasks:

  • Add wrapper in enum (globals.py) to fix [Lifter] Couldn't find target for type #214
  • rename StructTesting. StructValue? StructInstance? StructConstant?
  • update globals.py documentation
  • add an accept method for StructTesting
  • expose flags to settings (Problem: CExpressionGenerator does not have access to task object)
  • String representation for Structs
  • Fix issues introduced by merge with main
    • Fix hash/equality

0x6e62
0x6e62 approved these changes Aug 15, 2024
View reviewed changes
decompiler/backend/cexpressiongenerator.py Show resolved Hide resolved
decompiler/backend/cexpressiongenerator.py Show resolved Hide resolved
decompiler/backend/cexpressiongenerator.py Show resolved Hide resolved
decompiler/backend/variabledeclarations.py Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/globals.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/types.py Show resolved Hide resolved
decompiler/structures/pseudo/expressions.py Show resolved Hide resolved
decompiler/structures/pseudo/expressions.py Outdated Show resolved Hide resolved
decompiler/structures/pseudo/expressions.py Outdated Show resolved Hide resolved
decompiler/structures/pseudo/expressions.py Outdated Show resolved Hide resolved
0x6e62
0x6e62 requested changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@0x6e62 0x6e62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review #1

@0x6e62 0x6e62 merged commit c64d75b into main Aug 22, 2024
1 check passed
@0x6e62 0x6e62 deleted the initial_struct_support branch August 22, 2024 11:03
@blattm blattm mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blattm blattm blattm left review comments

@0x6e62 0x6e62 0x6e62 approved these changes

Assignees

@blattm blattm

@NeoQuix NeoQuix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeoQuix @blattm @0x6e62