Adding dummy_response option, allows for dry running #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
results, also helps with testing, added test
|
Helps with the |
whoisjones
pushed a commit
that referenced
this pull request
Oct 24, 2023
Adding dummy_response option, allows for dry running
whoisjones
pushed a commit
that referenced
this pull request
Oct 24, 2023
Adding dummy_response option, allows for dry running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces a
dummy_responseoption. Can be used instead of actual response of prompt node. Good for testing as user and developer.I chose a more flexibel approach, such that the user can decide what value is returned.
Can be a callable
lambda prompt: "Dummy movie response"or a string value. Open for alternatives.Also adjusted the tests for
DatasetGeneratorintest_dataset_generator.pyto not use a actual HF model. Can also be applied in other tests.