Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding darkness and brightness examples #2460

Closed
wants to merge 16 commits into from

Conversation

erickzanardo
Copy link
Member

Description

Adds two additional examples on the image stories for brightness and darkness changes on images.

Screen.Recording.2023-04-02.at.13.30.29.mov

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team April 2, 2023 16:32
@erickzanardo erickzanardo changed the title feat: adding darkness and brightness examples feat: Adding darkness and brightness examples Apr 2, 2023
@spydon spydon changed the title feat: Adding darkness and brightness examples docs: Adding darkness and brightness examples Apr 2, 2023
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@spydon
Copy link
Member

spydon commented Oct 11, 2023

The blue artifact is not there anymore, but it still produces a white rectangle on the transparent background.

@erickzanardo
Copy link
Member Author

The blue artifact is not there anymore, but it still produces a white rectangle on the transparent background.

@spydon ins't the white rectangle expected? I remember we discussed something about it internally?

@spydon
Copy link
Member

spydon commented Oct 12, 2023

@spydon ins't the white rectangle expected? I remember we discussed something about it internally?

That was because previously flame.png had a black background, but it has a transparent background now and a fully transparent color shouldn't be brightened? Maybe that is actually a bug in our code?

@CodeDoctorDE
Copy link
Contributor

Hi, I randomly found this pr here and I like the image example here. It would be nice if this could be merged so it can also be found easily on the website. What's missing? Can I help here?

@spydon
Copy link
Member

spydon commented Aug 14, 2024

Hi, I randomly found this pr here and I like the image example here. It would be nice if this could be merged so it can also be found easily on the website. What's missing? Can I help here?

As you can see in the video it wasn't working like intended. If you want to help you can checkout the PR, run the example and see if it works on the latest version of Flutter. :)

@spydon
Copy link
Member

spydon commented Dec 17, 2024

Commits from here added in #3414! 🥳

@spydon spydon closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants