Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add issue template #2812

Merged
merged 9 commits into from
Oct 17, 2023
Merged

docs: Add issue template #2812

merged 9 commits into from
Oct 17, 2023

Conversation

clairecharles
Copy link
Contributor

Description

This fixes #2805
I added a template to the issue form so you won't have to fill in the headers for an issue.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@clairecharles clairecharles changed the title DOCS: add issue template docs: add issue template Oct 11, 2023
@clairecharles clairecharles changed the title docs: add issue template docs: Add issue template Oct 11, 2023
@spydon
Copy link
Member

spydon commented Oct 11, 2023

Initially looks good, it should be updated to reflect what is in here though:
https://raw.githubusercontent.com/flame-engine/flame/main/.github/ISSUE_TEMPLATE/1_bug.md

And octocat should not be the default assignee. 😂

attributes:
label: What happened?
description: Tell us, what happened?
placeholder: Tell us what you see!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is need for a placeholder here

attributes:
label: What do you expect?
description: Also tell us, what behavior did you expect?
placeholder: Tell us what you want!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is need for a placeholder here

description: Also tell us, what behavior did you expect?
placeholder: Tell us what you want!
validations:
required: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be required

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
Comment on lines 44 to 66
# Steps to reproduce
<!-- This one is very important, please be very precise in how we can reproduce this bug -->
<!-- If possible please report steps based on the example from this plugin! -->
<!-- If you can make a minimal reproducible example it is incredibly helpful, the simplest way is to share a link from https://zapp.run, you can start from https://zapp.run/edit/flame where all dependencies are already set up. -->

# Flutter doctor output
<!-- Execute in a terminal and put output into code block below -->
```
Output of: flutter doctor -v
```

# More environment information
<!--
Create a list of more environment information, like:
* Flame version: 1.0.0
* Platform affected: android, ios, web
* Platform version affected: android 9, ios 13
-->

# More information
<!-- Do you have any other useful information about this bug report? Please write it down here -->
<!-- Possible helpful information: references to other sites/repositories -->
<!-- Are you interested in working on a PR for this? -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These questions should be part of the form

@clairecharles
Copy link
Contributor Author

Hi @spydon I have made changes to the file. Could you please look into it :)

Comment on lines 61 to 65
# Flutter doctor output
Execute in a terminal and put output into the code block below
```
Output of: flutter doctor -v
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Flutter doctor output
Execute in a terminal and put output into the code block below
```
Output of: flutter doctor -v
```
- type: textarea
id: logs
attributes:
label: flutter doctor
description: Execute `flutter doctor` in a terminal and put output into the code block below
render: shell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And similarly on all other markdown that is left underneath, so everything that starts with a # should have its own section that starts with type:

@clairecharles
Copy link
Contributor Author

Made a few changes :)

- name: Join us on Discord!
url: https://discord.gg/pxrBmy4
about: Ask your questions in our community!
name: Bug Report
Copy link

@anleac anleac Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: I'm not sure if this is the changeset we want; the change of the markdown looks solid 🙇 But I don't believe we should be modifying the config.yml but instead be creating a new file, bug_report.yml for example, in this same folder with the contents you've added (each new template/form should be it's own unique file).

More info here: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anleac does it look good now?

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @clairecharles!

@spydon spydon enabled auto-merge (squash) October 17, 2023 08:10
@spydon spydon merged commit 28bc371 into flame-engine:main Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use issue template forms for issues
3 participants