Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use flutter pub add to add flame dependency #2823

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Oct 17, 2023

Description

Use flutter pub add instead of munging the pubspec.yaml file for adding flame as a dependency

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Replace or remove this text.

@domesticmouse domesticmouse changed the title Use flutter pub add to add flame dependency docs: Use flutter pub add to add flame dependency Oct 17, 2023
doc/README.md Outdated

```console
$ flutter pub add flame
Resolving dependencies...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can skip the output of the command, it might confuse some beginners since it'll say different versions for them later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter spat the dummy because I had the $ before the command and no output. I can strip it back to just the command without upsetting the linter?

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I don't understand why it complains that consts isn't needed in the dictionary anymore, but I guess you can just remove it so that it becomes green.

@domesticmouse
Copy link
Contributor Author

Lgtm! I don't understand why it complains that consts isn't needed in the dictionary anymore, but I guess you can just remove it so that it becomes green.

Done!

@spydon spydon merged commit fa9665a into flame-engine:main Oct 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants