Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix namespace conflict with new Flutter class Split #3127

Closed
wants to merge 1 commit into from

Conversation

luanpotter
Copy link
Member

Description

Fix namespace conflict with new Flutter class Split.

Newer versions of Flutter seem to have introduced a Split class within animation curves which causes a compilation issue within Flame:

The name 'Split' is defined in the libraries 'package:devtools_app_shared/src/ui/split.dart (via package:devtools_app_shared/ui.dart)' and 'package:flutter/src/animation/curves.dart'.
Try using 'as prefix' for one of the import directives, or hiding the name from all but one of the imports.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon
Copy link
Member

spydon commented Apr 18, 2024

You don't have to worry about this, it has been renamed to SplitPane (it's for the devtools), we're just awaiting the release

@luanpotter
Copy link
Member Author

Sg, closing this then. It breaks with master that is need for 3d stuff.

@luanpotter luanpotter closed this Apr 18, 2024
@luanpotter luanpotter deleted the luan.fix-hide-split branch April 18, 2024 13:07
@spydon
Copy link
Member

spydon commented Apr 18, 2024

Sg, closing this then. It breaks with master that is need for 3d stuff.

We could merge this meanwhile if you want, it doesn't hurt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants