Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Larger menu overlay and better error text for platform+space shooter tutorials #3135

Merged
merged 5 commits into from
Apr 25, 2024
Merged

docs: Larger menu overlay and better error text for platform+space shooter tutorials #3135

merged 5 commits into from
Apr 25, 2024

Conversation

jessp01
Copy link
Contributor

@jessp01 jessp01 commented Apr 25, 2024

Description

  • doc/tutorials/ platformer/app/lib/overlays/main_menu.dart: adjust container height to avoid overflow
  • doc/tutorials/space_shooter/app/lib/main.dart: more descriptive error message when GET param (step) is missing

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

jessp01 added 3 commits April 25, 2024 12:11
@jessp01
Doc revisions
b4eced1
@jessp01
- doc/tutorials/ platformer/app/lib/overlays/main_menu.dart: adjust c…
25686cc 
…ontainer height to avoid overflow

- doc/tutorials/space_shooter/app/lib/main.dart: more descriptive error
  message when GET param (step) is missing
@jessp01
revert doc changes (submitted a different pull for that).
6aff6fb
@jessp01 jessp01 changed the title fix: Minor turotial changes Fix: Minor turotial changes Apr 25, 2024
@jessp01 jessp01 changed the title Fix: Minor turotial changes fix: Minor turotial changes Apr 25, 2024
@spydon spydon changed the title fix: Minor turotial changes docs: Larger menu overlay and better error text for platform+space shooter tutorials Apr 25, 2024
@spydon spydon merged commit e1abefd into flame-engine:main Apr 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessp01 @spydon