Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flame_3d): Fix minor nits on flame_3d #3140

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

luanpotter
Copy link
Member

Description

Fix minor nits on flame_3d, namely:

  • fix wrong bash command on the readme file
  • add missing git ignore to the example

This was extracted directly from @wolfenrain 's bigger PR, making it easier to merge later.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as ready for review April 27, 2024 21:35
@luanpotter luanpotter merged commit fcebf30 into flame_3d Apr 27, 2024
3 of 8 checks passed
@luanpotter luanpotter deleted the feat(flame_3d)-3d-updates branch April 27, 2024 21:37
luanpotter added a commit that referenced this pull request Jul 23, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Jul 27, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Aug 12, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Aug 25, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Sep 11, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Oct 15, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Dec 11, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Dec 11, 2024
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants