feat: Add onReleased action to AdvancedButtonComponent which will be called within onTapUp
#3152
Conversation
`AdvancedButtonComponent` doesn't show the `downSkin` if the action of `onPressed` changes the router to another page. That is because the router is changed before the `downSkin` is shown as the `onPressed` action is called in `onTapDown` instead of `onTapUp`. In this PR, calling `onPressed` action is moved to `onTapUp` method instead of `onTapDown`. That makes the `AdvancedButtonComponent` more natural and allows users to skip the action if they move the mouse pointer or their finger outside the button box.
|
The failed test case seems unrelated to my changes and all tests are passed locally with |
|
I don't think this is worth a breaking change, it's better to expose a callback for onTapUp. In UI's buttons often trigger in onTapUp, but in games, when mashing a fire button for example, you usually want onTapDown. |
|
Yeah, that makes sense. I didn't think about it, since I'm developing mainly board games, which are kind of UI apps. |
|
Does it worth adding a callback to the |
I think it would be worth adding! I guess we should add |
…ng onPressed behaviour
|
I have added |
mabdelaal86
changed the title
AdvancedButtonComponent call onPressed in onTapUp instead of onTapDownonReleased action to AdvancedButtonComponent which will be called within onTapUp
Sounds good! Then we can refactor it to |
|
Thanks a lot for the fast review |
Description
Add
onReleasedaction which will be called withinonTapUp. That fixed some scenarios which require the pressed action to be called after the user taps up the button.For example,
AdvancedButtonComponentdoesn't show thedownSkinif the action ofonPressedchanges the router to another page. That is because the router is changed before thedownSkinis shown as theonPressedaction is called inonTapDown.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Fixes #3150