Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken code example for ColorEffect #3382

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

bradcypert
Copy link
Contributor

@bradcypert bradcypert commented Dec 12, 2024

ColorEffect in the docs is using an positional parameter for opacityFrom, but its actually a named parameter.

Description

The docs example for ColorEffect is using a positional parameter instead of a named parameter, where the definition is using a named parameter.

Closes: #3383

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

ColorEffect in the docs is using an positional parameter for opacityFrom, but its actually a named parameter.
@spydon
Copy link
Member

spydon commented Dec 12, 2024

We're currently fixing the pipeline which broke when the new Flutter version was released, so this will be merged as soon as that is done.

@spydon spydon merged commit ac64f2c into flame-engine:main Dec 13, 2024
8 checks passed
@bradcypert bradcypert deleted the patch-1 branch December 15, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs show incorrect example for ColorEffect
3 participants