Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactoring flame_console to use terminui #3388

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

erickzanardo
Copy link
Member

@erickzanardo erickzanardo commented Dec 13, 2024

Description

Simplify flame_console to use terminui instead of implementing the terminal interface itself.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team December 13, 2024 17:47
@erickzanardo erickzanardo changed the title feat: refactoring flame_console to use terminui feat: Refactoring flame_console to use terminui Dec 13, 2024
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzanardo erickzanardo force-pushed the feat/flame_console_with_terminui branch from 2d5fdb2 to c5d111a Compare December 16, 2024 14:36
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@erickzanardo erickzanardo merged commit de74a93 into main Dec 16, 2024
8 checks passed
@erickzanardo erickzanardo deleted the feat/flame_console_with_terminui branch December 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants