Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bug preventing removeAll(children) from be called before mount #3408

Merged
merged 2 commits into from
Dec 14, 2024
Merged

fix: Fix bug preventing removeAll(children) from be called before mount #3408

merged 2 commits into from
Dec 14, 2024

Conversation

luanpotter
Copy link
Member

Description

Fix bug preventing removeAll(children) from be called before mount.

Fixes #2933

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter requested a review from spydon December 14, 2024 22:05
@spydon spydon merged commit 726cb8b into main Dec 14, 2024
8 checks passed
@spydon spydon deleted the luan.child-remove branch December 14, 2024 22:20
@itsdax itsdax mentioned this pull request Dec 25, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling remove and add components repeatedly during lifecycle change causes problem
2 participants
@luanpotter @spydon