Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix CircleShape.computeDistanceToOut and add some tests. #100

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: Fix CircleShape.computeDistanceToOut and add some tests. #100

merged 1 commit into from
Dec 18, 2024

Conversation

drrnbrns
Copy link
Contributor

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • (N/A) I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • (N/A) I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes #99.

@drrnbrns drrnbrns mentioned this pull request Dec 18, 2024
Closed
spydon
spydon approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for your contribution!

@spydon spydon merged commit 584a07e into flame-engine:main Dec 18, 2024
3 checks passed
@drrnbrns drrnbrns deleted the fix-circle-shape-compute-distance branch December 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fixture.computeDistance gives incorrect results for CircleShape
2 participants
@drrnbrns @spydon