-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update measurements.json to v2 format, and add a helper to load and compare #26
Conversation
cmd/get-measurements/main.go
Outdated
log.Info("Loading expected measurements from " + expectedMeasurementsPath + " ...") | ||
expectedMeasurements, err = multimeasurements.New(expectedMeasurementsPath) | ||
if err != nil { | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a log.Error message here for better understanding what went wrong while debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an error returned in the main function is still printed to the console. but still a valid point 👍
a9e8d32
to
d01c6a5
Compare
99238f6
to
fdfc6ce
Compare
"github.com/flashbots/cvm-reverse-proxy/internal/attestation/measurements" | ||
) | ||
|
||
// MultiMeasurements is holds several known measurements, and can check if a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the is
fdfc6ce
to
2794c9e
Compare
1c36ebb
to
5f466b8
Compare
2794c9e
to
4dec509
Compare
4dec509
to
16f88b4
Compare
Summary:
measurements.json
to v2 data schema, which allows additional data fields besides the raw measurements (i.e.attestation_type
. The v2 data schema is used at https://measurements.builder.flashbots.netMultiMeasurements
- a helper to load a list of measurements, and compare provided measurements against them. Can load both new and previous data schema.get-measurements
with the capability to load a reference list of mesaurements and compare the current one to the known ones.Data schema v2
Data schema v1
Usage with
get-measurements