Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: CI checks, make lint #9

Merged
merged 5 commits into from
Oct 2, 2024
Merged

cleanup: CI checks, make lint #9

merged 5 commits into from
Oct 2, 2024

Conversation

metachris
Copy link
Contributor

@metachris metachris commented Oct 2, 2024

  • Added CI checks (make lint and make test)
  • Fixed linting errors
  • Nice make output that shows all commands
  • Initial cvm-proxy-server Dockerfile

Sadly, I couldn't make golangci-lint work right away, it errors with this message:

$ golangci-lint run --exclude-dirs internal
WARN [runner] Can't run linter goanalysis_metalinter: buildir: failed to load package internal: could not load export data: no export data for "github.com/google/go-tpm-tools/simulator/internal" 
ERRO Running error: can't run linter goanalysis_metalinter
buildir: failed to load package internal: could not load export data: no export data for "github.com/google/go-tpm-tools/simulator/internal" 

keeping golangci-lint for a later PR


Output from make:

Screenshot 2024-10-02 at 12 58 26

README.md Outdated
@@ -8,6 +8,7 @@ This application provides a reverse proxy with TLS termination, supporting confi

- Client-side TLS termination with confidentialVM attestation verification.
- Server-side TLS termination with confidentialVM attestation verification.
- Mutual attestations between client and server.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will introduce a conflict with #8, maybe remove (the other one introduces this in some more detail)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, removed

@metachris metachris merged commit f7dba36 into main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants