Carrier-tx extension #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lashbots-bundle � Conflicts: � package-lock.json
kristofgazso
suggested changes
Aug 23, 2021
…s a list of its values and RLP encodes such list.
…t and still go through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all, creating my first PR for the repo: finalized the first version of the carrier-tx extension for the provider.
With these changes, users will be able to use the
publishmethod to submit a bundle through the public mempool, which can only be decrypted by a target validator, chosen by the user.Please note that currently:
publish()only returns aPromise<TransactionResponse>for the carrier transaction: I would like for this method to also return some details about the bundle, but I'm not sure how to implement this.publish()requires the user to pass it, among other things, a potentially emptyTransactionRequestto use as the carrier transaction: this object will be populated with default values if any of the following fields ['to', 'value', 'gasLimit', 'gasPrice', 'nonce'] are missing (I would love to be able to calculate the exact gasLimit for the carrier transaction, but found discording resources online noting different gas costs for every non-zero byte in a transaction's data field, anyone know what we could use?)MEV Prefixwhich I have set to0x0123as a placeholder, until a proper prefix is agreed upon.This extension has also been tested with a small script and I'm able to fully recreate the FlashbotsBundle passed as an argument to the
publish()method. Will not include it in this PR as I feel it doesn't regard this repo, will be happy to share the script if anyone wants to try for themselves.I'm also attaching a small file to showcase how one would use the extension.
carrierTx-demo.txt
Please let me know if any aspect of this is not clear to you, any doubts you may have, or if you would like further explanation on any aspect of this extension.
PS: all names have been selected solely by me, will gladly change them if we find better alternatives!