-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for gas fee refunds #555
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed, i didn't look for nits but mostly lgtm with two comments
|
||
## Who receives refunds | ||
|
||
The refund recipient is the signer used on the `eth_sendBundle`, `mev_sendBundle`, or `eth_sendPrivateTransaction` request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were defaulting to msg.sender unless there was an override?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true for protect (tx.origin not msg.sender to be precise). For anything sent directly to the bundle relay it's the signer because signer is always provided and this allows for separating eg. bot address from refund recipient which affords more privacy.
Changes:
eth_sendBundle
(which now supports multiplexing)eth_sendBundle
API spec to explain smart bundlesFollow ups:
flashbots_getSbundleStats
in a separate PR