Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoids shadowing metrics package in httpserver/server.go #30

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Avoids shadowing metrics package in httpserver/server.go #30

merged 2 commits into from
Jul 1, 2024

Conversation

Ruteri
Copy link
Contributor

@Ruteri Ruteri commented Jun 28, 2024 •
edited
Loading

📝 Summary

Avoids shadowing metrics package in httpserver/server.go.

⛱ Motivation and Context

I have to manually adjust this every time I clone from the template and I don't want to any more

📚 References

✅ I have run these commands

  • make lint
  • make test
  • go mod tidy

@metachris metachris merged commit afeb3de into main Jul 1, 2024
2 checks passed
@metachris metachris deleted the avoid-shadowing-metrics-import branch July 1, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metachris metachris metachris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruteri @metachris