feat: unified manifest; multiconfig, neutral layer #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoeMahhouk
reviewed
Dec 10, 2024
conf/multiconfig/rbuilder.conf
Outdated
Comment on lines
1
to
6
| # meta-evm deps | ||
| PACKAGE_INSTALL:append:pn-core-image-tiny-initramfs = " rbuilder orderflow-proxy system-api ssh-key-injection" | ||
| # meta-custom-podman deps | ||
| PACKAGE_INSTALL:append:pn-core-image-tiny-initramfs = " podman" | ||
| # meta- deps | ||
| PACKAGE_INSTALL:append:pn-core-image-tiny-initramfs = " fluent-bit prometheus node-exporter process-exporter mustache" |
There was a problem hiding this comment.
How are those different than the code inside core-image-tiny-initramfs.inc?
These are adding the dependencies directly here and there too?
Aren't those redundant? because the core-image-tiny-initramfs.inc is already including those recipes needed for the image and the recipes are having the other required dependencies in their RDEPENDS
There was a problem hiding this comment.
I've changed this to appending the distro features for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.