forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to include simulation event logs #84
Open
Code0x2
wants to merge
33
commits into
flashbots:mev-callbundle
Choose a base branch
from
Code0x2:aws-mainnet
base: mev-callbundle
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error with tx.origin being incorrect
Also fork ApplyTransaction to add in the result, so we can see revert reasons and return values
This leads to bad gas used calculations
jparyani
force-pushed
the
mev-callbundle
branch
from
August 24, 2021 15:19
c4cf5a9
to
7733fda
Compare
jparyani
force-pushed
the
mev-callbundle
branch
from
December 6, 2021 18:48
7733fda
to
4187c09
Compare
jparyani
force-pushed
the
mev-callbundle
branch
from
December 22, 2021 18:58
72a9c78
to
516e2c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simulationLogs param to eth_callBundle which toggles sending back the event logs of the transaction simulation.