US Treasury Auction Example #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested changes
Nov 22, 2023
|
|
||
| // Complete an auction and emit results | ||
| // Anyone can call this, as the creator sets the duration | ||
| // question: can/should it emit all bids for public verification? |
There was a problem hiding this comment.
It does not matter if you emit the bids, they are in the confidential store so they are not public. Normally, the pattern is to use the onchain callback to return the leak data of the bid that you want to expose.
|
|
||
| func main() { | ||
| fr := framework.New() | ||
| fr.DeployContract("TAuction.sol/TAuction.json") |
There was a problem hiding this comment.
Can you expand the example to also send the transactions?
| uint256 currentTotal = totalData.length > 0 ? abi.decode(totalData, (uint256)) : 0; | ||
| uint256 newTotal = currentTotal + amount; | ||
| Suave.confidentialStore(bid.id, "tauction:v0:noncompetitivetotal", abi.encode(newTotal)); | ||
| emit BidSubmitted(auctionId, bid.id); |
There was a problem hiding this comment.
In the current iteration, events cannot be emitted off-chain
| } | ||
|
|
||
| Auction[] public auctions; | ||
| mapping(uint256 => Suave.BidId[]) private _bids; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example of how to run US Treasury Auctions on SUAVE.
There are still some parts of the contract to fix, and the main.go script to write once that has happened.