Use latest Docker images for integration tests. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest image for flashbots/suave-geth.
lthibault
commented
Feb 1, 2024
| @@ -28,7 +28,6 @@ lt: lint test | |||
|
|
|||
| .PHONY: run-integration | |||
| run-integration: | |||
| go run examples/app-ofa-private/main.go | |||
There was a problem hiding this comment.
This test is broken and was causing the entire pipeline to fail. Removing it for now.
dmarzzz
approved these changes
Feb 1, 2024
No worries. Both of the images get rebuilt by the CI pipeline for suave-geth and suave-exec, respectively. This change ensures the latest image is used, rather than hard-coding a specific version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use flashbots/suave-execution-geth:lastest for suave-enabled chain.
Use latest image for flashbots/suave-geth.
This will allow
suapp-examplesto be pulled into the CI pipeline ofsuave-gethandsuave-execution-geth.