Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port web demo from suave-viem examples #34

Merged
merged 10 commits into from
Feb 29, 2024
Merged

port web demo from suave-viem examples #34

merged 10 commits into from
Feb 29, 2024

Conversation

zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Feb 21, 2024 •
edited
Loading

Standalone version of the web app provided in suave-viem examples.
Installs suave-viem from NPM (@flashbots/suave-viem@main).
Sends a simple CCR to an OFA Bid contract.

metachris
metachris reviewed Feb 21, 2024
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
@zeroXbrock zeroXbrock requested a review from metachris February 27, 2024 00:40
lthibault
lthibault suggested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to store examples/web-demo/bun.lockb in git, or is this an artifact that can be rebuilt by the user? Asking because I generally try to avoid "large" binary files in git, where possible.

examples/web-demo/src/bids.ts Outdated Show resolved Hide resolved
examples/web-demo/src/style.css Show resolved Hide resolved
examples/web-demo/src/vite-env.d.ts Show resolved Hide resolved
@zeroXbrock zeroXbrock requested a review from lthibault February 29, 2024 01:49
lthibault
lthibault approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zeroXbrock zeroXbrock merged commit bf4b505 into main Feb 29, 2024
2 checks passed
@zeroXbrock zeroXbrock deleted the web-demo branch February 29, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lthibault lthibault lthibault approved these changes

@metachris metachris Awaiting requested review from metachris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroXbrock @metachris @lthibault