Add builder example #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthibault
force-pushed
the
feat/builder
branch
from
9b7f364 to
b4944fa
Compare
dmarzzz
reviewed
Feb 25, 2024
|
|
||
| L1RPC string `env:"L1_RPC, default=http://localhost:8555"` | ||
|
|
||
| // This account is funded in your local SUAVE devnet | ||
| // address: 0xBE69d72ca5f88aCba033a063dF5DBe43a4148De0 | ||
| FundedAccountL1 *PrivKey `env:"L1_PRIVKEY, default=91ab9a7e53c220e6210460b65a7a3bb2ca181412a8a7b43ff336b3df1737ce12"` | ||
| FundedAccountL1 *PrivKey `env:"L1_PRIVKEY, default=6c45335a22461ccdb978b78ab61b238bad2fae4544fb55c14eb096c875ccfc52"` |
There was a problem hiding this comment.
Yes. This addresses the account funding issue.
There was a problem hiding this comment.
this account should be set to the devnet account that gets funded? but i guess if it passes tests its fine!
There was a problem hiding this comment.
Okay, I'll need to look into this a bit more and figure out exactly what's going on. I'm thinking we can ship this PR first, then add extra assertions to the test per your other comment, then investigate what's up with this account funding.
ferranbt
reviewed
Feb 26, 2024
lthibault
force-pushed
the
feat/builder
branch
from
07253a7 to
acf47fd
Compare
Closed
|
btw we should also rename from |
lthibault
force-pushed
the
feat/builder
branch
from
56e7420 to
a889dc8
Compare
zeroXbrock
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.