Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Connector.sol by itself #26

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

ferranbt
Copy link
Collaborator

@ferranbt ferranbt commented Jan 9, 2024

I have seen issues with #25 with the imported libraries when we run forge build from two different locations, the root and forge-gen.

This PR solves those issues by not compiling Connector.sol as part of the whole project but in isolation inside forge-gen.

@ferranbt ferranbt requested a review from metachris as a code owner January 9, 2024 17:17
@ferranbt ferranbt merged commit 5cb15b5 into main Jan 9, 2024
2 checks passed
@ferranbt ferranbt deleted the fix/forge-gen-deterministic-build branch March 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant