Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction RLP tweaks #30

Closed
wants to merge 8 commits into from
Closed

Transaction RLP tweaks #30

wants to merge 8 commits into from

Conversation

zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Jan 17, 2024 •
edited
Loading

proper RLP encoding for unsigned txs

to be reviewed after #28 is merged

  • removes r,s,v from Transaction.Legacy
  • adds chainId to Transaction.Legacy RLP encoding

@zeroXbrock zeroXbrock changed the title Feature/rlp transactions Transaction RLP tweaks Jan 17, 2024
@zeroXbrock
Copy link
Member Author

closing this, revising design in zeroXbrock#1

@zeroXbrock zeroXbrock closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroXbrock @ferranbt