Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock the confidential datastore for Foundry #40

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

ferranbt
Copy link
Collaborator

@ferranbt ferranbt commented Feb 2, 2024

This PR introduces a mock confidential datastore in Solidity compatible with the semantics provided by suave-geth. Then, it includes forge connectors to redirect the confidential store precompile calls to the mock.

@ferranbt ferranbt marked this pull request as ready for review February 2, 2024 16:29
@ferranbt ferranbt mentioned this pull request Feb 5, 2024
Copy link

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor point flagged inline.

@@ -0,0 +1,106 @@
// SPDX-License-Identifier: UNLICENSED

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a license?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is licensed for now. I will bring this up during weekly tomorrow.

@ferranbt ferranbt merged commit 983bab9 into main Feb 6, 2024
2 checks passed
@ferranbt ferranbt deleted the feature/mock-conf-store branch March 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants