Revert on Json RPC error #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pistomat
requested review from
ferranbt,
metachris and
zeroXbrock
as code owners
ferranbt
approved these changes
Jun 27, 2024
|
@ferranbt I synced with main, so maybe the CI passes now? I have no idea why there was a segfault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to get the error from a JSON RPC call if it fails, which is very annoying for both debugging and contract logic.
This is but a suggestion on how to handle it, alternatives that come up to my mind are:
resultitem.bool successto the return values, returningFalseand the error as string instead of reverting.