Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-publish.yml #458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mircealungu
Copy link
Member

the deploy:needs:[test] should not publish when the tests are failing cf. https://stackoverflow.com/a/63148947/1200070

the `deploy:needs:[test]` should not publish when the tests are failing cf. https://stackoverflow.com/a/63148947/1200070
@mircealungu mircealungu requested a review from JohannesLC April 27, 2024 11:46
@mircealungu
Copy link
Member Author

@JohannesLC - can you double check this? it looks good to me, but many eyes catch all the bugs :)

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.99%. Comparing base (1945759) to head (b6b7764).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files          95       95           
  Lines        3063     3063           
=======================================
  Hits         2726     2726           
  Misses        337      337           

@JohannesLC
Copy link
Collaborator

Hey @mircealungu
Looks good to me, but I tried running it locally and I seem to get unittests that fail and flask_monitoringdashboard/core/logger.py seem to give a circular reference, so we might need to fix those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants