-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pass version to Docker image #19
base: flatcar-master
Are you sure you want to change the base?
Conversation
.github/workflows/docker.yml
Outdated
@@ -47,3 +47,5 @@ jobs: | |||
platforms: linux/amd64,linux/arm64/v8 | |||
tags: ${{ steps.meta.outputs.tags }} | |||
labels: ${{ steps.meta.outputs.labels }} | |||
build-args: | |||
- VERSION=${{ steps.meta.outputs.tags }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately this will expand do something like: ghcr.io/flatcar-linux/ct:v0.9.3 ghcr.io/flatcar-linux/ct:latest
Signed-off-by: Mathieu Tortuyaux <[email protected]>
@jepio thanks - it almost works. On my fork, I keep hitting some issues:
I'll have a look tomorrow. |
@tormath1 were you ever able to figure it out? If not, might still be better to merge this than to not have versions :) |
@jepio thanks for the heads-up. I gave another try, still hitting the inconsistency but the change looks good to me according to the documentation. |
Latest release gave the following:
Instead of:
I think in the CI, we can't rely on Git to get the tag:
So let's try to explicitly pass the tag.