Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add ore command to create azure gallery #523

Draft
wants to merge 19 commits into
base: flatcar-master
Choose a base branch
from
Draft

WIP: add ore command to create azure gallery #523

wants to merge 19 commits into from

Commits on Aug 12, 2024

  1. platform/api/azure: Add features to published gallery 

    We want to indicated support for trusted launch (TPM + secure boot) for
testing. Trusted launch is only availabe for Gen2 VMs so we need some
conditional template magic to continue working for Gen1 VMs. We also
need to indicate image support for NVMe for testing NVMe only instances.
For completeness we also mark support for accelerated networking.

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    60c10e5 View commit details
    Browse the repository at this point in the history

  2. cmd/ore/azure: Use flatcar instead of coreos in paths 

    Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    3f5bbec View commit details
    Browse the repository at this point in the history

  3. cmd/ore/azure: Call StartLogging manually 

    Since all ore commands call WrapPreRun, they overwrite the default
implementation that calls StartLogging(). To get plog to work
StartLogging() must be called manually.

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    592ef95 View commit details
    Browse the repository at this point in the history

  4. cmd/ore/azure: Initialize platform.Options 

    So that commands can set fields like 'Board' later on.

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    126e656 View commit details
    Browse the repository at this point in the history

  5. cmd/ore/azure: Add command to create-gallery-image 

    This ore command creates a gallery image for use in multiple VM
creations, and could be used to speed up multiple kola invocations.  The
command takes care of uploading the vhd to blob storage and creates
resource group and storage account as well.

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    570a340 View commit details
    Browse the repository at this point in the history

  6. platform/api/azure: Enable TPM for Gen2 instances 

    Now that our gallery images are created with trusted launch support, we
can enable trusted launch and TPM on the instance. At some point we'll
be able to pass custom secure boot keys too.

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    fee9ed9 View commit details
    Browse the repository at this point in the history

  7. platform/azure: Reuse single storage account for boot logs 

    We currently create a storage account for every test cluster. Storage account
creation takes 20-30 seconds. This storage account is only used for VM console
logs. We can easily reuse a single storage account for all vm console logs,
thereby speeding up the whole test execution.

Introduce a field called storageAccountRG in struct cluster, so that we can
keep track of the correct RG when fetching VM logs.

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a0dc3d1 View commit details
    Browse the repository at this point in the history

  8. make trusted launch opt-in

    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f5bd2b4 View commit details
    Browse the repository at this point in the history

  9. platform/api/azure: Ignore -gen2 suffix on sku when resolving latest … 

    …version

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2e8a354 View commit details
    Browse the repository at this point in the history

  10. kola: Use skip func to skip cl.misc.nvidia 

    Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a641d2a View commit details
    Browse the repository at this point in the history

  11. kola: Make RunTests return on runtime failures 

    So that the deferred flight.Destroy() is called. The only caller terminates the
application on failure anyway.
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    beb1ad0 View commit details
    Browse the repository at this point in the history

  12. disable force vm delete 

    This makes it harder to track down legit failures.
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    11ade1f View commit details
    Browse the repository at this point in the history

  13. TMP: azure: fetch console log from failed provisioning

    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e391ca1 View commit details
    Browse the repository at this point in the history

  14. TMP: azure: timeout after 15s

    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    4e69e8c View commit details
    Browse the repository at this point in the history

  15. TMP: retry: Sleep after failure

    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c38c12d View commit details
    Browse the repository at this point in the history

  16. azure: Switch to managed boot diagnostics for console 

    This does not require that the user have RBAC permissions to a storage account
to fetch, because it uses SAS keys behind the scenes. The previous approach
used a kola created storage account has Shared Key Access disabled for security
reasons.

Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    524e36f View commit details
    Browse the repository at this point in the history

  17. TMP: azure: Save screenshot on failure

    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f253c39 View commit details
    Browse the repository at this point in the history

  18. Revert "TMP: azure: timeout after 15s" 

    This reverts commit 2647b48.
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    426d223 View commit details
    Browse the repository at this point in the history

  19. TMP: azure: add instance name to provisioning failure log 

    Signed-off-by: Jeremi Piotrowski <[email protected]>
    @jepio
    jepio committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    05e3cf3 View commit details
    Browse the repository at this point in the history