Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: remove SAS URL generation #549

Merged
merged 1 commit into from
Aug 7, 2024
Merged

azure: remove SAS URL generation #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions cmd/plume/prerelease.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,15 +329,6 @@ func azurePreRelease(ctx context.Context, client *http.Client, src *storage.Buck
if err != nil {
return err
}
sas, err := azure.SignBlob(client, container, blobName)
if err != nil {
plog.Fatalf("signing failed: %v", err)
}
url := azure.BlobURL(client, container, blobName)
plog.Noticef("Generated SAS: %q from %q for %q", sas, url, specChannel)
imageInfo.Azure = &azureImageInfo{
ImageName: sas, // the SAS URL can be used for publishing and for testing with kola via --azure-blob-url
}
}
return nil
}
Expand Down
7 changes: 0 additions & 7 deletions cmd/plume/release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ func doAzure(ctx context.Context, client *http.Client, src *storage.Bucket, spec

plog.Printf("Signing %q in %q on %v...", blobName, container, environment.CloudName)

var url string
blobExists, err := azure.BlobExists(client, container, blobName)
if err != nil {
plog.Fatalf("failed to check if blob %q in account %q container %q exists: %v", blobName, spec.Azure.StorageAccount, container, err)
Expand All @@ -415,12 +414,6 @@ func doAzure(ctx context.Context, client *http.Client, src *storage.Bucket, spec
plog.Notice("Blob does not exist, skipping.")
return
}
url, err = azure.SignBlob(client, container, blobName)
if err != nil {
plog.Fatalf("signing failed: %v", err)
}
plog.Noticef("Generated SAS: %q for %q", url, specChannel)
plog.Noticef("Please update the SKU manually (or try to automate this step)!")
}
}

Expand Down