-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Move manifests to a saner location #1304
Open
krnowak
wants to merge
10
commits into
main
Choose a base branch
from
krnowak/move-manifests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI passed. |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6651965781 |
This was referenced Oct 26, 2023
Submodules are not a thing any more.
krnowak
force-pushed
the
krnowak/move-manifests
branch
from
November 1, 2023 16:47
22e8934
to
047d6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1149/cldsv/
This moves the manifests directory from
sdk_container/.repo/manifests
to the toplevelmanifests
directory. The location of manifests inside the SDK container is made a bit more consistent by moving it from/mnt/host/sources/.repo/manifests
to/mnt/host/sources/src/scripts/manifests
.Other related PRs:
Reasons:
sdk_container/.repo/manifest
is just a ridiculously obscure location for a file that sourced and checked everywhere..repo
is probably a leftover from Google'srepo
tool, which we don't use any more.I want
/mnt/host/sources/
to stop being a mountpoint (this is wheresdk_container
directory is mounted).run_sdk_container
but adding volumes to/host/mnt/sources/src
makes a mess in the scripts repository. So this manifests directory move is a first step to avoid mountingsdk_container
directory to/mnt/host/sources
. We could instead mount coreos-overlay and portage-stable in/mnt/host/sources/src/third_party
./mnt/scripts
as a mountpoint only, without thissources/src/third_party
nonsense.Changelog entries added in the respective
changelog/
directory (user-facing change, bug fix, security fix, update)Inspected CI output for image differences:
/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.