-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nvidia container toolkit #1705
Draft
jepio
wants to merge
10
commits into
main
Choose a base branch
from
jepio/nvidia-container-toolkit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From scratch because the guru one patches too match and is going to break too much. This package is primarily supposed to provide nvidia-container-cli. Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
nvidia-persistenced keeps a reference to the GPU open at all times, which allows applications/containerd accessing gpus to start faster. Signed-off-by: Jeremi Piotrowski <[email protected]>
Created using `nvidia-ctk config generate-default`. Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
Nvidia CDI definitions are used by Kubernetes to represent the topology of GPUs available to a node and allow workload placement on suitable GPUs. Signed-off-by: Jeremi Piotrowski <[email protected]>
To prevent mksquashfs from spamming the console about btrfs.compression. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
jepio/nvidia-container-toolkit
branch
from
February 27, 2024 06:48
99e0f34
to
2d930c7
Compare
pothos
reviewed
Feb 27, 2024
@@ -102,7 +102,7 @@ rm -rf "${sysext_workdir}" "${sysext_output_dir}" | |||
mkdir "${sysext_workdir}" "${sysext_output_dir}" | |||
|
|||
info "creating temporary base OS squashfs" | |||
sudo mksquashfs "${root_fs_dir}" "${sysext_base}" -noappend | |||
sudo mksquashfs "${root_fs_dir}" "${sysext_base}" -noappend -xattrs-exclude '^btrfs.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to silence this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Title: describe the change in one sentence]
[ describe the change in 1 - 3 paragraphs ]
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.