Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-kernel/coreos-modules: Enable VFIO for arm64 #2484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukasstockner
Copy link

Enable VFIO for arm64

VFIO was configured as x86-only, but it also works and is useful on ARM.
CONFIG_VFIO_PCI_VGA is x86-specific, so it remains in the amd64 config.

How to use

  • Build and run Flatcar image
  • modprobe vfio_pci
  • Bind a PCI device to vfio-pci

Testing done

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

VFIO was configured as x86-only, but it also works and is useful on ARM.
CONFIG_VFIO_PCI_VGA is x86-specific, so it remains in the amd64 config.
Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! We'll let CI pass and then this can be merged.

@lukasstockner
Copy link
Author

Thanks for the quick review!
Looks like the CI failed, but I don't see how the error is related to the change. Is this something you've seen before?

@ader1990
Copy link
Contributor

Thanks for the quick review! Looks like the CI failed, but I don't see how the error is related to the change. Is this something you've seen before?

Hello, the CI failed because it could not use the code from your branch, it is expected when making a PR from a fork.

Copy link

Build action triggered: https://github.com/flatcar/scripts/actions/runs/12053931792

@@ -0,0 +1 @@
- The VFIO kernel modules are now also available in ARM64 builds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The VFIO kernel modules are now also available in ARM64 builds.
- The VFIO kernel modules are now also available in ARM64 builds. ([flatcar/scripts#2484](https://github.com/flatcar/scripts/pull/2484))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants