Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions of the format 0.x.y should be considered stable #359

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Mar 17, 2023

Fixes #338, fixes #358

This will consider all versions with a maj́or version of 0 as stable when using the gnome checker.


This is currently not covered by tests, as alleyoop only has one version branch 0.9.x: https://github.com/flathub/flatpak-external-data-checker/blob/890dd4b8d6fca69539ccdc5c53727f55716877fc/tests/org.gnome.baobab.json#L15-L18
this will not trigger the behaviour, as it will fallback to the single unstable version branch if no other stable version is available.

@gasinvein gasinvein force-pushed the gnome-stable-versions-major-0 branch from fef9ba7 to ef8568c Compare March 18, 2023 09:53
@gasinvein
Copy link
Collaborator

I've fixed the unrelated test failure (timeout on httpbin.org) and rebased your branch.

Although I'm not entirely sure this is correct. Doesn't Gnome use the odd-for-unstable version scheme for 0.x.y versions, too?

@gasinvein gasinvein force-pushed the gnome-stable-versions-major-0 branch from ef8568c to 9e17445 Compare March 18, 2023 10:12
@hfiguiere
Copy link

I think #374 would help a lot.

@wjt wjt merged commit a6cb87d into flathub-infra:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect downgrade of rest. Script requests to update to an older version
4 participants