This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Add meta tags for social share #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzeee
commented
Oct 5, 2021
| this.app.screenshots[0].imgDesktopUrl | ||
| ) { | ||
| this.meta.addTags([ | ||
| { name: 'og:image', content: this.app.screenshots[0].imgDesktopUrl }, |
There was a problem hiding this comment.
We could use the app icon instead, I'm not sure what we want here. If we go for the first screenshot, we should have a fallback to the icon.
razzeee
force-pushed
the
social-share
branch
2 times, most recently
from
b8f866a
to
98872b8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic share previews for socials. This is still rough and needs to be completed. But it's hard to test them without having them hosted.