Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixtures for issue #59 #60

Closed
wants to merge 4 commits into from

Conversation

dougalcampbell
Copy link

Here are my tests for issue #59, "Another nested object problem"

@framp
Copy link

framp commented Jul 26, 2012

Thanks for the fix!

After using plates for quite some time I got the same bug you described in issue #59
It's pretty easy to get caught by this one, still don't understand how I didn't manage to trigger it before!

The main problem here is that we're trying to parse HTML by using regular expressions (http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags)

I'm not sure how much having a proper xml parser would impact speed, but using regex is quite bug prone in my book.

Hope this get merged up!

@dougalcampbell
Copy link
Author

Yeah, even though I came up with a patch that worked for me (never did get around to making an updated pull request, though), I wasn't 100% happy with it. It seems brittle, and I keep thinking there's some other edge-case lurking in there. Glad if it helped you, though.

@indexzero
Copy link
Member

Thank you for your contribution, but closing this due to age. This project is formally deprecated. Will be adding a notice soon.

@indexzero indexzero closed this Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants