Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clickIconToClose #269

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

matthieu-hm
Copy link

This pull request add the missing EventEmitter clickIcon & make works clickIconToClosefor all notification type (not only "html")
In the same time I added a class .has-icon to add paddind to .sn-title & .sn-content only if the notification has an icon

@flauc
Copy link
Owner

flauc commented Nov 13, 2017

Can you please resolve any conflicts, it looks like some of the additions you made were included in a previous fork as well.

@supetronix
Copy link

any update on this issue? This and "No clickIcon EventEmitter on Notification #282" seems to be related and I am stuck on this issue too. I tried to use following option overrides:
clickToClose: false,
clickIconToClose: true

but nothing happened. Then I tried to use the notification HTML method. It successfully made icon hover effect but it would throw "emitter" error.

I am looking at "ngx-toastr" as an alternative if this one doesn't work out. It has almost all features, except that global settings are only available in "forRoot" method.

@bernatgy
Copy link

bernatgy commented Jun 4, 2020

Woah. It should be noted in README that this project is not maintained. This is a 3 years old issue, and there are plenty more old ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants