Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterised aspects of the identicon #2

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Parameterised aspects of the identicon #2

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5f9277e
Parameterised aspects of the identicon
McPo May 29, 2018
107d986
Changed from f string to .format
McPo May 29, 2018
32ea74b
Bumped version number
McPo May 29, 2018
b456798
Fixed issues regarding different python versions
McPo May 29, 2018
b39b069
Added parameter for image type
McPo May 30, 2018
cdd4e58
Merge branch 'added-more-parameters' of https://github.com/McPo/ident…
McPo May 30, 2018
3753c53
Now calculating color via HLS
McPo May 30, 2018
6357657
added lightness and saturation parameters
McPo May 30, 2018
0d5ef17
Fixed tests
McPo May 30, 2018
63730e2
Dont round as identicon.js does not
McPo May 30, 2018
7b5e968
Renamed parameters
McPo May 30, 2018
6cbb99f
Made it so you can pass the hash directly in
McPo May 30, 2018
413a26d
Updated changes
McPo May 30, 2018
a75e02e
Resolved integer/float division issue on Python2.7
McPo May 30, 2018
15f58ed
Finished renaming a parameter
McPo May 30, 2018
b649695
Fixed tests
McPo May 31, 2018
cfb10c7
Fixed an major issue. setup.py was importing Identicon, which was in …
McPo Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Identicon/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _extract_color(hex_list):
r,g,b =tuple(hex_list[i:i+2]
for i in range(0, 2*3, 2))

return f'#{r}{g}{b}'
return '#{r}{g}{b}'.format(r=r,g=g,b=b)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to show the reference link on it, use format() rather than f sigil


def _build_grid(hex_list, number_of_blocks):
# Tailing hex_list to rear 15 bytes
Expand Down